[PATCH 1/3] wineps.drv: Make the Unicode name-sorted glyph table fully const.

Erich E. Hoover erich.e.hoover at wine-staging.com
Thu Sep 17 09:16:30 CDT 2015


On Thu, Sep 17, 2015 at 2:25 AM, Henri Verbeet <hverbeet at gmail.com> wrote:
> On 16 September 2015 at 19:22, Erich E. Hoover
> <erich.e.hoover at wine-staging.com> wrote:
>> So yes, this works.
>>
> It does something for patch 3, but I'd be very surprised if it did
> anything for the first two. (Though for what it's worth, the version
> of gcc I have (4.9.2) seems to put "glyph_table" in .data.rel.ro even
> before making the table const, as long as the compiler can determine
> it's never written to.)

I already admitted that I misread the other two thinking there was a
table of pointers.  If you'd like I'd happily resend part 3 on its
own.

> But note the "WRITE" flag on .data.rel.ro. While .data.rel.ro is
> slightly better than .data, it's only made read-only after processing
> relocations. It's not going to do much for e.g. .so load times. If you
> really wanted to put the various tables in .rodata you'd have to
> replace the string pointers in GLYPHNAME with indices into a string
> table. Since those tables seem to be generated that's probably
> feasible, although whether it's worth the effort is a different
> question.

I do not, personally, have time to do that.  My work is pressuring me
to get a lot of things done on an incredibly short timescale, so I
have very little time for Wine at the moment.  All of my recent
activity has actually been to get something running for work - this
was just to do a quick cleanup that was suggested on IRC that I
clearly didn't pay enough attention to.

Best,
Erich



More information about the wine-devel mailing list