user32: Use top level window as dialog parent for modal dialogs.
dmitry at baikal.ru
Wed Apr 6 04:43:12 CDT 2016
Alexandre Julliard <julliard at winehq.org> wrote:
> > P.S.
> > I'm not the person who commits patches to Wine, why are you arguing with me
> > if it's pretty clear that you are not going to write any tests at all in order
> > to demonstrate that your patch is correct?
> I'm not committing the patches until I'm satisfied that the tests are
> sufficient, and if you feel that they are not, I want to understand why,
> and make sure that the necessary tests get written. Your technical
> feedback is welcome and appreciated.
I think that I've already described the technical details about both the source
of the regression that Jacek is trying to fix, and the fact that the tests that
could confirm that the fix is correct simply don't exist at all.
> But accusing Jacek of refusing to write tests at all is neither true nor
> helpful. It would be nice if you could refrain from such comments and
> concentrate on technical issues, where I believe that you do have useful
> knowledge to contribute. Can we please all try to get along?
So, is Jacek actually going to write the tests that would help avoiding new
regressions in the area of dialog owner enable/disable management logic
instead of pretending that his patch fixes something else?
More information about the wine-devel