[PATCH 2/2] cmd: Add support for || and &&.
sebastian at fds-team.de
Thu Apr 7 15:36:26 CDT 2016
On 07.04.2016 22:12, Qian Hong wrote:
> Slightly improved based on Mikhail Bystryantsev's patch, add support for those built-in commands which does not change %ERRORLEVEL%.
> Signed-off-by: Qian Hong <qhong at codeweavers.com>
> programs/cmd/builtins.c | 14 +++++++++++---
> programs/cmd/tests/test_builtins.cmd | 13 +++++++++++++
> programs/cmd/tests/test_builtins.cmd.exp | 13 ++++++++++++-
> programs/cmd/tests/test_cmdline.cmd | 20 ++++++++++++++++++++
> programs/cmd/tests/test_cmdline.cmd.exp | 22 ++++++++++++++++++++++
> programs/cmd/wcmd.h | 1 +
> programs/cmd/wcmdmain.c | 26 ++++++++++++++++++++++++--
> 7 files changed, 103 insertions(+), 6 deletions(-)
Has it really something to do with builtin-commands which do not change %ERRORLEVEL%?
I think the tests only cover one of those commands, a couple of additional tests would
probably not hurt. The lack of tests is also the reason why I haven't merged this into
Staging yet. If this turns out to be right way to solve it, I would suggest to define
a function check_errorlevel() which checks 'errorlevel' and 'changed' at once.
More information about the wine-devel