[PATCH 1/4] dsound: Rework ugly mixer logic

Andrew Eikum aeikum at codeweavers.com
Fri Apr 8 13:59:09 CDT 2016


On Fri, Apr 08, 2016 at 08:47:36PM +0200, Henri Verbeet wrote:
> On 8 April 2016 at 20:37, Andrew Eikum <aeikum at codeweavers.com> wrote:
> > From: Maarten Lankhorst <maarten.lankhorst at canonical.com>
> >
> > Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>
> > ---
> >  dlls/dsound/dsound.c         |   1 -
> >  dlls/dsound/dsound_main.c    |   6 --
> >  dlls/dsound/dsound_private.h |   6 +-
> >  dlls/dsound/mixer.c          | 252 +++++++++++--------------------------------
> >  dlls/dsound/primary.c        | 107 ++++++++----------
> >  5 files changed, 108 insertions(+), 264 deletions(-)
> >
> You're the one that has to maintain this, so I don't care all too
> much, but this looks like it's doing a bunch of different things under
> a pretty vague commit message.

Looking at it again, you're right. The code is much cleaner on the
other side, but there is a lot stuffed into one patch. I'll see how
well I can split it up.

Andrew



More information about the wine-devel mailing list