[PATCH 3/5] user32: Don't enable owner in DIALOG_DoDialogBox.

Jacek Caban jacek at codeweavers.com
Mon Apr 11 08:47:40 CDT 2016

On 04/11/16 14:24, Dmitry Timoshkov wrote:
> Jacek Caban <jacek at codeweavers.com> wrote:
>>> Actually the fact that you can't reproduce the described above behaviour
>>> with in your own tests tells quite a bit (yes, EndDialog() is not supposed
>>> to enable a previously disabled owner under some conditions).
>> Yes, that's the case if you reparent the dialog. My tests show that and
>> implementation behaves as expected. We don't need DF_OWNERENABLED for that.
> If you mean the trick with GWLP_HWNDPARENT then I'm not sure it's the best
> or really correct way of solving the problem. But yes, it looks like a good
> workaround.

I'm going to ignore your comment about not being correct or being a
workaround because they are not backed by any technical argument. All
that's left is that it works as expected so your previous concern is
already addressed by the patch. Thanks.


More information about the wine-devel mailing list