[PATCH 1/2] d3drm/tests: Add tests for IDirect3DRM*::CreateObject (v2).

Henri Verbeet hverbeet at gmail.com
Tue Apr 12 08:17:24 CDT 2016

On 11 April 2016 at 20:04, Aaryaman Vasishta <jem456.vasishta at gmail.com> wrote:
> +        hr = IDirect3DRM_CreateObject(d3drm1, NULL, NULL, tests[i].iid, (void **)&unknown);
> +        todo_wine ok(hr == D3DRMERR_BADVALUE, "Test %u: expected hr == D3DRMERR_BADVALUE, got %#x.\n", i, hr);
Note that mentioning the expected value is mostly redundant here. It's
obvious as soon as you look at the test source, and test output isn't
generally useful without that.

> +        hr = IDirect3DRM_CreateObject(d3drm1, tests[i].clsid, NULL, tests[i].iid, (void **)&unknown);
> +        todo_wine ok(SUCCEEDED(hr), "Test %u: expected hr == D3DRM_OK, got %#x.\n", i, hr);
> +        if (SUCCEEDED(hr))
> +        {
I'll point out that if you had done a "continue" on failure instead,
you wouldn't need to change the indentation when you remove the

More information about the wine-devel mailing list