[PATCH v2] ole32: Fix memory leak in CompositeMonikerImpl_Construct.

Alexandre Julliard julliard at winehq.org
Wed Apr 13 00:52:50 CDT 2016


Alex Henrie <alexhenrie24 at gmail.com> writes:

F> Coverity #713613, "Variable This going out of scope leaks the storage it
> points to."
>
> If we need to loop through This->tabMoniker and call IMoniker_Release on
> each of its items, we should do the same in the other three similar
> error paths in this function. Please let me know if this is what you
> want.

Yes, even if Coverity doesn't warn about the reference leaks, it should
be fixed completely, otherwise once the warning is gone we'll forget
about it.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list