[PATCH 2/3] d3drm/tests: Replace test_Texture.

[Aaryaman Vasishta]

On Sun, Apr 24, 2016 at 3:43 PM, Stefan Dösinger <stefandoesinger at gmail.com>
wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Am 2016-04-24 um 06:40 schrieb Aaryaman Vasishta:
> > +    size = 1;
> > +    hr = IDirect3DRMTexture_GetClassName(texture1, &size, cname);
> > +    ok(hr == E_INVALIDARG, "GetClassName failed with %x\n", hr);
> > +    size = sizeof(cname);
> > +    hr = IDirect3DRMTexture_GetClassName(texture1, &size, cname);
> > +    ok(SUCCEEDED(hr), "Cannot get classname (hr = %x)\n", hr);
> > +    ok(size == sizeof("Texture"), "wrong size: %u\n", size);
> sizeof("Texture") is confusing IMHO. I had to look up the C rules on
> string literals to make sure it does what you want :-) . Though I'm not
> sure if its better than strlen("Texture") + 1, so it's your call.
>
> However, the current implementation in d3drm_texture3_GetClassName
> confuses the two. I recommend adding a test for sizeof("Texture") - 1
> and an exactly matching size.
>
> I hadn't really paid attention to that since the plan was to just extend
the existing tests to version 2 and 3. But I will add these tests as you
want.
By exactly matching size, did you mean sizeof("Texture") itself? Isn't that
already there? I might have missed something here.

Cheers,
Aaryaman
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20160424/4100fe37/attachment.html>