[PATCH 3/5] qedit: Implement IAMTimelineObj_GetTimelineType and add tests.

Alex Henrie alexhenrie24 at gmail.com
Mon Apr 25 23:52:05 CDT 2016


2016-04-25 22:18 GMT-06:00 Nikolay Sivov <bunglehead at gmail.com>:
> On 26.04.2016 6:09, Alex Henrie wrote:
>>  static HRESULT WINAPI TimelineObj_GetTimelineType(IAMTimelineObj *iface, TIMELINE_MAJOR_TYPE *type)
>>  {
>>      TimelineObjImpl *This = impl_from_IAMTimelineObj(iface);
>> -    FIXME("(%p)->(%p): not implemented!\n", This, type);
>> -    return E_NOTIMPL;
>> +    TRACE("(%p)->(%p)\n", This, type);
>> +    *type = This->timeline_type;
>> +    return S_OK;
>>  }
>
> Is it supposed to handle NULL input?

No, it's not. Good catch.

-Alex



More information about the wine-devel mailing list