[PATCH 5/5] qedit: Implement IAMTimelineObj_GetTimelineNoRef and add tests.

[Alex Henrie]

2016-04-25 22:21 GMT-06:00 Nikolay Sivov <bunglehead at gmail.com>:
> On 26.04.2016 6:10, Alex Henrie wrote:
>>  static HRESULT WINAPI TimelineObj_GetTimelineNoRef(IAMTimelineObj *iface, IAMTimeline **timeline)
>>  {
>> +    /* MSDN says that this function is "not supported" */
>>      TimelineObjImpl *This = impl_from_IAMTimelineObj(iface);
>> -    FIXME("(%p)->(%p): not implemented!\n", This, timeline);
>> -    return E_NOTIMPL;
>> +    TRACE("(%p)->(%p)\n", This, timeline);
>> +    if (!timeline) return E_POINTER;
>> +    return E_NOINTERFACE;
>>  }
>
> This looks like a call to QI, according to your tests.

It looks that way, but which interface would it be querying? The tests
show that an IAMTimelineObj cannot double as an IAMTimeline, nor is
the function supposed to return the IAMTimeline that was used to
create the IAMTimelineObj. My best guess is that Microsoft never
bothered implementing this function properly and so whatever
implementation they have always winds up returning E_NOINTERFACE.

-Alex