[6/6] wininet: Handle INTERNET_INVALID_PORT_NUMBER in HttpOpenRequest.

Sebastian Lackner sebastian at fds-team.de
Tue Apr 26 09:13:30 CDT 2016


On 26.04.2016 14:44, Jacek Caban wrote:
> Note that get_server already has code to deal with
> INTERNET_INVALID_PORT_NUMBER, so it would be enough to handle https case
> there. However, given that all other callers have valid port numbers, I
> agree that it would be cleaner to do that in HTTP_HttpOpenRequestW
> instead. Given that your moving the logic around, please remove no
> longer needed code there.
> 
> Thanks,
> Jacek
> 
> 

I will resend a fix for this after the first bunch of patches is accepted.
Removing the code from get_server() would probably not be sufficient, it
looks like HTTP_DealWithProxy() might also depend on it.

Regards,
Sebastian




More information about the wine-devel mailing list