server: Fix detection of duplicate console history lines. (v2)

Alexandre Julliard julliard at winehq.org
Thu Apr 28 07:24:41 CDT 2016


Sebastian Lackner <sebastian at fds-team.de> writes:

> Signed-off-by: Sebastian Lackner <sebastian at fds-team.de>
> ---
> Changes in v2:
> * We can't really use memcmp because it could allow exploits with special input,
>   like "abc\0def", where it would probably compare past the end of the string.

Note that you don't need special input, any comparison with a shorter
string can potentially overrun.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list