[PATCH 1/3] user32/tests: Moved creating .ico file into a helper function.

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=22746

Your paranoid android.


=== w864 (32 bit cursoricon) ===
cursoricon.c:1436: Test failed: Create cursor failed.
cursoricon.c:1441: Test failed: GetIconInfo() failed.
cursoricon.c:1443: Test failed: Last error: 1402
cursoricon.c:1458: Test failed: DestroyCursor() failed.
cursoricon.c:1460: Test failed: Last error: 1402
cursoricon.c:1593: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1600: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1601: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0).
cursoricon.c:1602: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1).
cursoricon.c:1608: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1620: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1626: Test failed: Unexpected number of steps in cursor (0 != 3)
cursoricon.c:1635: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1637: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1638: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1641: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1635: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1637: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1.
cursoricon.c:1638: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1641: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1635: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1637: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2.
cursoricon.c:1638: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1641: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1660: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1666: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1672: Test failed: Unexpected number of steps in cursor (0 != 1)
cursoricon.c:1679: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1681: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1682: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1685: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0).
cursoricon.c:1702: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1714: Test failed: Create cursor failed (error = deadbeef).
cursoricon.c:1720: Test failed: Unexpected number of steps in cursor (0 != 3)
cursoricon.c:1731: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1733: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1734: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de).
cursoricon.c:1737: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1731: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1733: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1.
cursoricon.c:1734: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe).
cursoricon.c:1737: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1731: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1733: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2.
cursoricon.c:1734: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe).
cursoricon.c:1737: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1745: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:2603: Test failed: LoadImage() failed with 0.
cursoricon.c:2603: Test failed: LoadImage() failed with 0.

=== w1064 (32 bit cursoricon) ===
cursoricon.c:1436: Test failed: Create cursor failed.
cursoricon.c:1441: Test failed: GetIconInfo() failed.
cursoricon.c:1443: Test failed: Last error: 1402
cursoricon.c:1458: Test failed: DestroyCursor() failed.
cursoricon.c:1460: Test failed: Last error: 1402
cursoricon.c:1593: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1600: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1601: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0).
cursoricon.c:1602: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1).
cursoricon.c:1608: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1620: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1626: Test failed: Unexpected number of steps in cursor (0 != 3)
cursoricon.c:1635: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1637: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1638: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1641: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1635: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1637: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1.
cursoricon.c:1638: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1641: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1635: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1637: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2.
cursoricon.c:1638: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1641: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1660: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1666: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1672: Test failed: Unexpected number of steps in cursor (0 != 1)
cursoricon.c:1679: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1681: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1682: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1685: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0).
cursoricon.c:1702: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1714: Test failed: Create cursor failed (error = deadbeef).
cursoricon.c:1720: Test failed: Unexpected number of steps in cursor (0 != 3)
cursoricon.c:1731: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1733: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1734: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de).
cursoricon.c:1737: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1731: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1733: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1.
cursoricon.c:1734: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe).
cursoricon.c:1737: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1731: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1733: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2.
cursoricon.c:1734: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe).
cursoricon.c:1737: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1745: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:2603: Test failed: LoadImage() failed with 0.
cursoricon.c:2603: Test failed: LoadImage() failed with 0.

=== w864 (64 bit cursoricon) ===
cursoricon.c:1436: Test failed: Create cursor failed.
cursoricon.c:1441: Test failed: GetIconInfo() failed.
cursoricon.c:1443: Test failed: Last error: 1402
cursoricon.c:1458: Test failed: DestroyCursor() failed.
cursoricon.c:1460: Test failed: Last error: 1402
cursoricon.c:1593: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1600: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1601: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0).
cursoricon.c:1602: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1).
cursoricon.c:1608: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1620: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1626: Test failed: Unexpected number of steps in cursor (0 != 3)
cursoricon.c:1635: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1637: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1638: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1641: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1635: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1637: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1.
cursoricon.c:1638: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1641: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1635: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1637: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2.
cursoricon.c:1638: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1641: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1660: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1666: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1672: Test failed: Unexpected number of steps in cursor (0 != 1)
cursoricon.c:1679: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1681: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1682: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1685: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0).
cursoricon.c:1702: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1714: Test failed: Create cursor failed (error = deadbeef).
cursoricon.c:1720: Test failed: Unexpected number of steps in cursor (0 != 3)
cursoricon.c:1731: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1733: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1734: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de).
cursoricon.c:1737: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1731: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1733: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1.
cursoricon.c:1734: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe).
cursoricon.c:1737: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1731: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1733: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2.
cursoricon.c:1734: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe).
cursoricon.c:1737: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1745: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:2603: Test failed: LoadImage() failed with 0.
cursoricon.c:2603: Test failed: LoadImage() failed with 0.

=== w1064 (64 bit cursoricon) ===
cursoricon.c:1436: Test failed: Create cursor failed.
cursoricon.c:1441: Test failed: GetIconInfo() failed.
cursoricon.c:1443: Test failed: Last error: 1402
cursoricon.c:1458: Test failed: DestroyCursor() failed.
cursoricon.c:1460: Test failed: Last error: 1402
cursoricon.c:1593: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1600: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1601: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0).
cursoricon.c:1602: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1).
cursoricon.c:1608: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1620: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1626: Test failed: Unexpected number of steps in cursor (0 != 3)
cursoricon.c:1635: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1637: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1638: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1641: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1635: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1637: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1.
cursoricon.c:1638: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1641: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1635: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1637: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2.
cursoricon.c:1638: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1641: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1660: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1666: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1672: Test failed: Unexpected number of steps in cursor (0 != 1)
cursoricon.c:1679: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1681: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1682: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1685: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0).
cursoricon.c:1702: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1714: Test failed: Create cursor failed (error = deadbeef).
cursoricon.c:1720: Test failed: Unexpected number of steps in cursor (0 != 3)
cursoricon.c:1731: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1733: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1734: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de).
cursoricon.c:1737: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1731: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1733: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1.
cursoricon.c:1734: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe).
cursoricon.c:1737: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1731: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1472: Test failed: GetIconInfo() failed
cursoricon.c:1733: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2.
cursoricon.c:1734: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe).
cursoricon.c:1737: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1745: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:2603: Test failed: LoadImage() failed with 0.
cursoricon.c:2603: Test failed: LoadImage() failed with 0.