[PATCH] d3dx9: Remove dead assignment (Coverity)

Nikolay Sivov bunglehead at gmail.com
Fri Aug 5 14:12:00 CDT 2016


On 05.08.2016 21:57, Matteo Bruni wrote:
> 2016-08-04 8:17 GMT+02:00 Nikolay Sivov <nsivov at codeweavers.com>:
>> Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
>> ---
>>
>> It's overwritten right after if block.
>>
>>  dlls/d3dx9_36/mesh.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/dlls/d3dx9_36/mesh.c b/dlls/d3dx9_36/mesh.c
>> index 3204ea7..c26aa72 100644
>> --- a/dlls/d3dx9_36/mesh.c
>> +++ b/dlls/d3dx9_36/mesh.c
>> @@ -5662,7 +5662,6 @@ static HRESULT create_outline(struct glyphinfo *glyph, void *raw_outline, int da
>>                          pt->corner = POINTTYPE_CURVE_END;
>>                  }
>>                  outline->count--;
>> -                lastpt = &outline->items[outline->count - 1];
>>              } else {
>>                  /* outline closed with a line from end to start point */
>>                  attempt_line_merge(outline, outline->count - 1, &pt->pos, FALSE, cos_table);
>> --
>> 2.8.1
> 
> Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
> 
> BTW, there is exactly the same issue in the tests in tests/mesh.c line 3737.
> 
> 

Ok, will try to remember to remove it too.



More information about the wine-devel mailing list