[PATCH] advapi32: Allow for sending extended control events to services

[Aric Stewart]

On 8/8/16 11:28 PM, Sebastian Lackner wrote:
> On 08.08.2016 17:41, Aric Stewart wrote:
>>
>> This allows dwEventType and lpEventData parameters to be sent
>>
>> Signed-off-by: Aric Stewart <aric at codeweavers.com>
>> ---
>>  dlls/advapi32/service.c | 36 ++++++++++++++++++++++++++++--------
>>  include/wine/svcctl.idl | 11 ++++++++++-
>>  2 files changed, 38 insertions(+), 9 deletions(-)
>>
> 
> It might be useful to validate the parameters received from the control pipe
> before assuming its safe to access the data. The existing code is also not
> really perfect yet, however it wouldn't hurt to add some checks.
> 

Since the existing code does not do it either then maybe that would be a good followup patch.


> Nevertheless, even more important, it would also be good to combine this in
> a series with the corresponding programs/services part, so that it can be
> tested and we are sure this is the right way to solve it.
> 
> Best regards,
> Sebastian
> 

I can send those but it is still a long enough and complicated enough chain that I feel like there will be quite a bit of work each step before you get your tests. But this was a nice clean part that could be pulled out and put in as foundation.  I can send the whole series for comment but the last few time I have done that it has been met with silence, which was not very helpful.

Pull it apart into small atomic groundwork pieces has been far more productive. 

-aric