[PATCH 2/3] d3drm: Implement IDirect3DRMFrame*::GetScene. (v6)

Aaryaman Vasishta jem456.vasishta at gmail.com
Mon Aug 15 05:17:12 CDT 2016


On Mon, Aug 15, 2016 at 3:37 PM, Henri Verbeet <hverbeet at gmail.com> wrote:

> On 12 August 2016 at 01:09, Aaryaman Vasishta <jem456.vasishta at gmail.com>
> wrote:
> > +    IDirect3DRMFrame3_AddRef(*scene = &frame->IDirect3DRMFrame3_iface);
> Actually, sorry, you probably shouldn't do that in d3drm. The d3drm
> headers are written by hand, so IDirect3DRMFrame3_AddRef() is a macro
> instead of an inline function. That means that when this expands the
> assignment happens twice.
>
>
> No problem. Thanks for the explanation :)
You can sign-off on v5 of this patch, then? (125544)

Cheers,
Aaryaman
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20160815/b4c6d979/attachment.html>


More information about the wine-devel mailing list