[PATCH 2/3] d3drm: Implement IDirect3DRMFrame*::GetScene. (v6)

Henri Verbeet hverbeet at gmail.com
Mon Aug 15 05:26:53 CDT 2016


On 15 August 2016 at 12:19, Aaryaman Vasishta <jem456.vasishta at gmail.com> wrote:
> Sorry, I meant 125481 (v4). Should I resend that one?
>
Well no, that one has other issues. This patch looks otherwise fine to
me, but you should split

    IDirect3DRMFrame3_AddRef(*scene = &frame->IDirect3DRMFrame3_iface);

into

    *scene = &frame->IDirect3DRMFrame3_iface;
    IDirect3DRMFrame3_AddRef(*scene);



More information about the wine-devel mailing list