[PATCH 2/2] d3drm: Implement IDirect3DRMViewport*::Clear. (v3 resend)

Henri Verbeet hverbeet at gmail.com
Tue Aug 16 07:43:08 CDT 2016


On 15 August 2016 at 21:50, Aaryaman Vasishta <jem456.vasishta at gmail.com> wrote:
> +    memcpy(&driver, &IID_IDirect3DRGBDevice, sizeof(GUID));
Why not "driver = IID_IDirect3DRGBDevice;"?

It probably also makes sense to introduce a helper function to create
d3drm devices at some point.

> +    hr = IDirect3DMaterial_SetMaterial(viewport->material, &mat);
> +
> +    return hr;
"return IDirect3DMaterial_SetMaterial(viewport->material, &mat);"

> +    if (FAILED(hr = IDirect3DViewport_Clear(viewport->d3d_viewport, 1, &clear_rect, clear_flags)))
> +               return hr;
Formatting.



More information about the wine-devel mailing list