[PATCH 3/4] d3d11: Add tests for WINED3DFMT_BC7_UNORM format.

Józef Kucia joseph.kucia at gmail.com
Mon Aug 22 02:24:28 CDT 2016


On Mon, Aug 22, 2016 at 1:21 AM, Kimmo Myllyvirta
<kimmo.myllyvirta at gmail.com> wrote:
> d3d11.c:5937: Test failed: Test 16: Failed to create 2d texture, hr
> 0x80070057.
> wvistau64, w2008s64 etc. fails because BC7 and BC6H needs at least feature
> level 11.0. There's no existing mechanism in texture_test to skip specific
> texture tests conditionally based on feature level (add min feature level to
> the texture_tests array?).

It's probably fine to add the required feature level to the
"texture_tests" array but make sure that it's optional. The other
option (which has some advantages) is to simply hardcode the formats
and required feature levels in the for loop, i.e. add a condition
similar to "if (... && test->texture->format == ... && feature_level <
...)".

>
> d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (0,
> 0)
> The test expects 0xff0000fc, I'm getting 0xff0000fb and 0xff0000fd.
> 0xff0000fa doesn't fit into the +-1 range. Some completely different texture
> might work, dunno.
>
> I'll wait for additional comments before making patch V2.

Increasing the range to +- 2 should be ok.



More information about the wine-devel mailing list