[PATCH v8 1/3] shell32/tests: Add tests for FolderItems_Item and FolderItems_get_Count.

Sebastian Lackner sebastian at fds-team.de
Mon Aug 22 05:15:57 CDT 2016


On 19.08.2016 11:43, Alex Henrie wrote:
> Cc: Sebastian Lackner <sebastian at fds-team.de>
> 
> v8 initializes V_ERROR(&var), item, item2, and i correctly. It also adds
> checks that the test files were created and written successfully.
> 
> Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
> ---
>  dlls/shell32/tests/Makefile.in     |   2 +-
>  dlls/shell32/tests/shelldispatch.c | 229 +++++++++++++++++++++++++++++++++++--
>  2 files changed, 219 insertions(+), 12 deletions(-)
> 

I think this patch is unfortunately still a bit too noisy to be applied
separately. If you want to keep the "bruteforce" tests I would suggest to
move the implementation into the first patch, or alternatively change the
FIXME to a TRACE. Besides that I am basically fine, although there are
probably some ways how to improve the code style a bit further.

Regards,
Sebastian




More information about the wine-devel mailing list