[PATCH v8 3/3] shell32: Implement FolderItems_get_Count.

[Alex Henrie]

2016-08-22 4:16 GMT-06:00 Sebastian Lackner <sebastian at fds-team.de>:
> On 19.08.2016 11:43, Alex Henrie wrote:
>> Cc: Sebastian Lackner <sebastian at fds-team.de>
>>
>> Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
>> ---
>>  dlls/shell32/shelldispatch.c       | 10 ++++++++--
>>  dlls/shell32/tests/shelldispatch.c |  6 ------
>>  2 files changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/dlls/shell32/shelldispatch.c b/dlls/shell32/shelldispatch.c
>> index a456ad4..86b77d6 100644
>> --- a/dlls/shell32/shelldispatch.c
>> +++ b/dlls/shell32/shelldispatch.c
>> @@ -1061,9 +1061,15 @@ static HRESULT WINAPI FolderItemsImpl_Invoke(FolderItems3 *iface,
>>
>>  static HRESULT WINAPI FolderItemsImpl_get_Count(FolderItems3 *iface, LONG *count)
>>  {
>> -    FIXME("(%p,%p)\n", iface, count);
>> +    FolderItemsImpl *This = impl_from_FolderItems(iface);
>>
>> -    return E_NOTIMPL;
>> +    TRACE("(%p,%p)\n", iface, count);
>> +
>> +    if (!count)
>> +        return E_INVALIDARG;
>
> The tests contain a comment which suggests that Windows does not do such checks.
> If this is true I would suggest to simplify it also here in your implementation.

Good catch.

-Alex