[PATCH] user32/tests: Add tests for LockWindowUpdate.

Lauri Kenttä lauri.kentta at gmail.com
Thu Dec 8 12:49:10 CST 2016


On 2016-12-08 18:14, Alexandre Julliard wrote:
> Lauri Kenttä <lauri.kentta at gmail.com> writes:
> 
>> On 2016-12-08 17:58, Alexandre Julliard wrote:
>>> Lauri Kenttä <lauri.kentta at gmail.com> writes:
>>> 
>>>> v2: Win8 and Win10 give different results (sometimes even
>>>> different different results), so mark some cases as broken.
>>>> Also simplify the patch overall.
>>> 
>>> I don't think that painting on the desktop window is a very useful
>>> test,
>>> and it can fail for various reasons. If the goal is to test
>>> LockWindowUpdate, you should do that with top-level windows instead.
>> 
>> If painting to desktop is not interesting, then bug 52 (the oldest
>> open bug) should probably be closed.
> 
> As I mentioned in a comment there, that's mostly a WONTFIX. There may 
> be
> a use for LockWindowUpdate in other cases, but scribbling over the
> desktop is not a particularly interesting case.

I thought your comment was about virtual desktop vs. WM integration.
Are you now extending that WONTFIX to virtual desktop as well?
In that case, I'd really close bug 52, which is about the desktop.

I shortly tested IDA 5 Free (as suggested by Bruno), and I didn't notice
any weird glitches. Let someone open a new bug if there's a real 
(useful)
application that really needs this function.

Anyway, I'm sending v3 with parent+child tests instead of desktop tests,
just in case. If that doesn't work out, I'll just move on to another 
bug.

-- 
Lauri Kenttä



More information about the wine-devel mailing list