[PATCH] shlwapi: Changed UrlEscapeW error paths and add tests
Fabian Maurer
dark.shadow4 at web.de
Tue Dec 13 16:29:34 CST 2016
On Tuesday, December 13, 2016 11:13:51 PM CET Jacek Caban wrote:
> Please send wininet changes as separated patch. They don't depend on
> shlwapi, so may be applied separately, before shlwapi patch.
Well they do kind of depend on the shlwapi changes. HTTP_HandleRedirect relies
on wine behaviour that doesn't work on windows. With only the shlwapi changes,
HTTP_HandleRedirect would break. Should I still split them up?
On Tuesday, December 13, 2016 11:13:51 PM CET Jacek Caban wrote:
> You set and test size although the actual call doesn't use it. Please
> remove lines with size. Same in a few more cases.
Oh yes, I missed that. Thanks for pointing it out.
Fabian
More information about the wine-devel
mailing list