[PATCH 2/7] reg: Split reg_printfW into separate functions

Alexandre Julliard julliard at winehq.org
Mon Feb 8 07:12:05 CST 2016


Hugh McMaster <hugh.mcmaster at outlook.com> writes:

> On Monday, 8 February 2016 20:06:55 +0900, Alexandre Julliard wrote:
>> 
>> Hugh McMaster writes:
>> 
>>> +static void __cdecl output_array(const WCHAR *fmt, ...)
>>> +{
>>> +    __ms_va_list va_args;
>>> +
>>> +    __ms_va_start(va_args, fmt);
>>> +    output_formatstring(fmt, va_args);
>>> +    __ms_va_end(va_args);
>>>  }
>> 
>> That's a strange name, why "array"?
>
> Well, we use array syntax for string literals. So it's just for differentiating between string resources (as messages)
> and string literals (as arrays).
>
> I also used the name in http://source.winehq.org/git/wine.git/commitdiff/4335c464c358d15024e76c918efb7721ff0d9cce
> and it slipped past back then!  :-)

Right, I probably assumed that you meant the uninstalled programs array
back then, not the string. Of course technically strings are also
arrays, but that's a confusing name. Just name it output_string or
something like that.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list