[PATCH 5/7] wined3d: Copy channel info for typed formats from typeless formats.

Henri Verbeet hverbeet at gmail.com
Wed Feb 10 10:32:42 CST 2016


On 10 February 2016 at 17:22, Józef Kucia <joseph.kucia at gmail.com> wrote:
>> I'm not sure this is really the way to go. I'd prefer to just reorder
>> things in such a way that the format id is the index in all cases
>> except for FourCC formats. Patch 7/7 goes a long way in that
>> direction, but to me it looks more complicated than just having a
>> small table to remap the FourCC formats to an index. One additional
>> advantage would be that we could then also remap e.g. DXT2 and DXT3 to
>> BC2. E.g.:
>
> It's mostly temporary before something equivalent to patch 7/7.
Yeah, but it could probably be avoided if that patch came first.

> We
> could reorder format ids in enum wined3d_format_id so the only thing
> needed would be a table to remap the FourCC formats. However, I think
> this is very fragile and easy to break. Also, it makes some things
> harder to change. For example, changing a default internal format
> requires reordering entries in the typed_formats table.
Oh, no, I don't mean for the various tables in utils.c, just for
gl_info.formats. So conceptually what patch 7/7 does, but instead of
looking for holes to put the FourCC formats in just have the remap
table for those.



More information about the wine-devel mailing list