[v3 PATCH] gdi32: Support Begin/End Path for metafile DCs

Huw Davies huw at codeweavers.com
Tue Feb 16 06:21:30 CST 2016


On Tue, Feb 16, 2016 at 08:04:00PM +0800, Dmitry Timoshkov wrote:
> Huw Davies <huw at codeweavers.com> wrote:
> > But isn't that just because we only test ExtTextOut()?  For example, we
> > don't even test the contents of the emf created in test_emf_GetPath().
> 
> That's a good point. EMF contents get tested in test_emf_ExtTextOut_on_path()
> and test_mf_ExtTextOut_on_path() though. Alistair, please add a test for EMF
> contents in addition to what GetPath() returns, see other tests how to do that,
> there is a helper that will generate appropriate data for you.

Adding something more than MoveTo/LineTo would be good too.  In addition
a test for wmfs would be interesting.

> > What I'm wondering is whether we need to do this to more than just
> > ExtTextOut.
> 
> That's also a good point, but it would be a separate effort I'd guess.

If we need to do this for many functions, we probably want to look
for another way; so I'd like to understand the problem first.

Huw.



More information about the wine-devel mailing list