[PATCH 2/2 v3] user32: Add more dialog creation message tests

Dmitry Timoshkov dmitry at baikal.ru
Tue Feb 16 23:20:25 CST 2016


Piotr Caban <piotr at codeweavers.com> wrote:

> On 02/16/16 14:08, Dmitry Timoshkov wrote:
> > It's getting better, but again doesn't show a lot of details. Please add
> > parameters for most of the recorded messages in the sequence, in particular
> > EM_SETSEL and WM_GETDLGCODE are the mandatory ones. Also, in order to see
> > the origin of EM_SETSEL I'd suggest to call DefDlgProc() manually and use
> > defwndproc_counter around it together with the defwinproc flag.
> 
> DefDlgProc can't be called manually in this case. There are already some 
> comments about it in the tests.

TestDlgProcA() calls DefDlgProc() this way without any problem. Even of
calling DefDlgProc() is not desirable from inside of a dialog procedure
for some reason, then the reason should be explained, and it's always
possible to call DefDlgProc() outside of dialog proc directly and record
the produced messages, there are examples in the tests how to do that.

-- 
Dmitry.



More information about the wine-devel mailing list