[PATCH] d3d10core/tests: Silence absolute value warnings. (Clang)

Henri Verbeet hverbeet at gmail.com
Tue Feb 23 11:35:11 CST 2016


On 19 February 2016 at 23:50, Charles Davis <cdavis5x at gmail.com> wrote:
> Signed-off-by: Charles Davis <cdavis5x at gmail.com>
> ---
For what it's worth, writing something like "Silence ... warnings" in
the subject line is a good way to get a patch rejected on principle.
However, we do have similar casts in the d3d9 tests because there's
actually an issue, albeit a pretty pedantic one. (Unsigned to signed
conversion is implementation defined for values that can't be
represented with the signed type, but any implementation we care about
is going to do the right thing.)

I'll also use the occasion to note that I have my reservations about
LLVM/Clang as a project.



More information about the wine-devel mailing list