[PATCH 2/3] user32: Added more dialog owner tests.
Dmitry Timoshkov
dmitry at baikal.ru
Mon Feb 29 17:25:57 CST 2016
Jacek Caban <jacek at codeweavers.com> wrote:
> >>> Please don't create fake embedded blocks.
> >> I need this declaration here, otherwise I wouldn't be able to use
> >> handles for testing lparam value.
> > wparam/lparam could be tested directly in the window procedure.
>
> It would require some global variables and new window procedure. It's
> cleaner to do it using existing tools IMO.
Writing the tests for user32 requires a bit of efforts, yes. But since
you are new to this area I think it's justified to ask for more tests
to show that you well understand the code and can proof that the patch
is 100% correct.
--
Dmitry.
More information about the wine-devel
mailing list