[PATCH 2/3] user32: Added more dialog owner tests.

Alexandre Julliard julliard at winehq.org
Mon Feb 29 20:32:35 CST 2016


Dmitry Timoshkov <dmitry at baikal.ru> writes:

> Jacek Caban <jacek at codeweavers.com> wrote:
>> I'm not sure I agree.
>
> Please don't get me wrong, but when sending tests after the fixes the result
> can't be easily verified, and therefore this reduces the trust and value of
> patches.

There are many cases where adding todos and then removing them creates
more work, so it's perfectly acceptable to send a test to apply after
the fix to demonstrate that it is correct. We do that all the time.

If you don't trust that the test is testing the right thing, it's easy
enough to verify by reverting the fix and confirming that the test
fails. I do that frequently myself.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list