[PATCH] user32: Allow WM_CAPTURECHANGE indicating SetCapture() parameter. (try 2)
Sebastian Lackner
sebastian at fds-team.de
Fri Jan 1 19:13:14 CST 2016
On 01.01.2016 23:50, Christopher Thielen wrote:
> Fixes https://bugs.winehq.org/show_bug.cgi?id=13683
>
> A window may be notified with WM_CAPTURECHANGED about itself
> gaining mouse capture if it calls SetCapture() twice.
>
> Tested on Windows XP and Fedora Workstation 22.
>
> Re-submitting to simplify based on wine-devel feedback.
> Re-submitting after 1.8 release.
>
> Signed-off-by: Christopher Thielen <cthielen at gmail.com>
>
Where are the tests you initially had in your patch? I assume you accidentially
resent an old version. The tests are still useful to make sure, that noone will
break this fix again.
Also, please review all the occurances of WM_CAPTURECHANGED, and fix them
accordingly. If the code doesn't look like it can handle the double
notification, then just ignore them based on the condition lParam == hWnd. This
could also be done in separate patches before.
Regards,
Sebastian
More information about the wine-devel
mailing list