read_file_test doesn't look right

Alex Henrie alexhenrie24 at gmail.com
Mon Jan 4 21:14:09 CST 2016


Dear Mike and Alexandre,

The function read_file_test in dlls/ntdll/tests/file.c [1] has a lot
of lines like this:

    ok( is_signaled( event ), "event is not signaled\n" );

This makes sense to me. The first parameter is the condition we want
(a signal), and the second parameter is the error message to display
if we didn't get what we want (no signal). However, there are also a
lot of lines like this:

    ok( is_signaled( event ), "event is signaled\n" );

Either this is a mistake or in some cases a zero return value does
indicate that the event was signaled. What is going on here?

I made a patch to make these messages look like I think they should.
If you approve, I will send the patch on to wine-patches.

-Alex

[1] https://source.winehq.org/git/wine.git/blob/93d7356290bfe5bfd2104f98592790841e33420e:/dlls/ntdll/tests/file.c#l633



More information about the wine-devel mailing list