[1/2] kernel32: add stub for GetSystemPreferredUILanguages

Stefan Leichter Stefan.Leichter at camLine.com
Tue Jan 5 03:26:45 CST 2016


Hello Matteo,

thank you for your review ...

Am 04.01.2016 um 22:05 schrieb Matteo Bruni:
> 2015-12-30 10:21 GMT+01:00 Stefan Leichter <Stefan.Leichter at camline.com>:
>> The function is called from VSWinExpress.exe (Visual Studio 2013/12.0
>> Express Edition)
>>
>> Signed-off-by: Stefan Leichter <Stefan.Leichter at camLine.com>
>> ---
>>   .../api-ms-win-core-localization-l1-2-0.spec       |  2 +-
>>   .../api-ms-win-core-localization-l1-2-1.spec       |  2 +-
>>   dlls/kernel32/kernel32.spec                        |  2 +-
>>   dlls/kernel32/locale.c                             | 26
>> ++++++++++++++++++++++
>>   include/winnls.h                                   |  1 +
>>   5 files changed, 30 insertions(+), 3 deletions(-)
>
> Just a drive-by comment: I think it would be nicer if the FIXME was at
> the start of the function i.e. before the early returns.

To my understanding [1] a FIXME should be printed when something needs 
to be improved, which is not the case for the early returns.

>
> I would also replace PULONG and PZZWSTR with ULONG * and WCHAR *, not
> sure what's the convention in kernel32 though.
>
I will send an updated patch set containing this modification.

>
>
Regards Stefan

[1] https://www.winehq.org/docs/winedev-guide/debugging#DBG-CLASSES



More information about the wine-devel mailing list