[PATCH] quartz: Handle NULL target format in FilterGraph::ConvertTimeFormat.

Nikolay Sivov bunglehead at gmail.com
Wed Jan 6 07:06:34 CST 2016


On 05.01.2016 14:13, Anton Baskanov wrote:
> Signed-off-by: Anton Baskanov <baskanov at gmail.com>
> ---
>  dlls/quartz/filtergraph.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c
> index 5b4b080..5cb670e 100644
> --- a/dlls/quartz/filtergraph.c
> +++ b/dlls/quartz/filtergraph.c
> @@ -2530,6 +2530,9 @@ static HRESULT WINAPI MediaSeeking_ConvertTimeFormat(IMediaSeeking *iface, LONGL
>      if (!pSourceFormat)
>          pSourceFormat = &This->timeformatseek;
>  
> +    if (!pTargetFormat)
> +        pTargetFormat = &This->timeformatseek;
> +
>      if (IsEqualGUID(pTargetFormat, pSourceFormat))
>          *pTarget = Source;
>      else
> 

Hi, Anton.

According to msdn this looks correct to me. Could you add a simple test
for that? Let's say one test with both formats as NULL; and a couple
more with one format being NULL and another set to current format.

Looks like it could be added easily to test_mediacontrol() as it has
everything you'd need.



More information about the wine-devel mailing list