[7/8] bcrypt: Add support for SHA hashes on Linux using Nettle.
Bruno Jesus
00cpxxx at gmail.com
Wed Jan 6 08:16:48 CST 2016
On Wed, Jan 6, 2016 at 8:19 PM, Hans Leidekker <hans at codeweavers.com> wrote:
> Signed-off-by: Hans Leidekker <hans at codeweavers.com>
> ---
> configure.ac | 18 +++++++++
> dlls/bcrypt/Makefile.in | 1 +
> dlls/bcrypt/bcrypt_main.c | 95 +++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 114 insertions(+)
Hi, Hans. Great job in the patch series, but Is this change really
necessary? Can't we reuse the internal libraries from rsaenh? I think
it was a copy of tomcrypt lib, I'm not able to check right now. By
using rsaenh or moving the tomcrypt to a more generic place it could
be reused without need for external dependencies, right? Unless I'm
missing something obvious.
Best wishes,
Bruno
More information about the wine-devel
mailing list