[PATCH] xaudio2: Added missing break in a switch (Coverity)

Nikolay Sivov bunglehead at gmail.com
Thu Jan 7 08:13:45 CST 2016


On 07.01.2016 0:06, Andrew Eikum wrote:
> On Wed, Jan 06, 2016 at 05:56:05PM +0300, Nikolay Sivov wrote:
>> Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
>> ---
>>  dlls/xaudio2_7/xaudio_dll.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/dlls/xaudio2_7/xaudio_dll.c b/dlls/xaudio2_7/xaudio_dll.c
>> index e7176b2..1f5a91f 100644
>> --- a/dlls/xaudio2_7/xaudio_dll.c
>> +++ b/dlls/xaudio2_7/xaudio_dll.c
>> @@ -449,6 +449,7 @@ static ALenum get_al_format(const WAVEFORMATEX *fmt)
>>              case 8:
>>                  return AL_FORMAT_71CHN8;
>>              }
>> +            break;
>>          case 16:
> 
> Could you also add a break to the 16 case?

I can, but it ends on case 16, so there's nothing to fall through to. Or
you mean purely for consistency?

> 
> Thanks,
> Andrew
> 
> 




More information about the wine-devel mailing list