winhttp: Avoid -Wmisleading-indentation warning in test_IWinHttpRequest_Invoke.

Nikolay Sivov bunglehead at gmail.com
Sun Jan 10 05:52:26 CST 2016


On 10.01.2016 14:26, Gerald Pfeifer wrote:
> This is a bit unusual formatting, though I understand where it's coming 
> from.  Adding braces silences GCC 6's new -Wmisleading-indentation.
> 
> Gerald
> 
> Signed-off-by: Gerald Pfeifer <gerald at pfeifer.com>
> ---
>  dlls/winhttp/tests/winhttp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/dlls/winhttp/tests/winhttp.c b/dlls/winhttp/tests/winhttp.c
> index d676dd8..1408f35 100644
> --- a/dlls/winhttp/tests/winhttp.c
> +++ b/dlls/winhttp/tests/winhttp.c
> @@ -3820,8 +3820,9 @@ static void test_IWinHttpRequest_Invoke(void)
>      ok(hr == DISP_E_UNKNOWNINTERFACE, "error %#x\n", hr);
>  
>      VariantInit(&ret);
> -if (0) /* crashes */
> +if (0) /* crashes */ {
>      hr = IWinHttpRequest_Invoke(request, DISPID_HTTPREQUEST_OPTION, &IID_NULL, 0, DISPATCH_PROPERTYPUT, NULL, &ret, NULL, &err);
> +}
>  
>      params.cArgs = 1;
>      hr = IWinHttpRequest_Invoke(request, DISPID_HTTPREQUEST_OPTION, &IID_NULL, 0, DISPATCH_PROPERTYPUT, &params, &ret, NULL, &err);
> 

I think we have tons of those, I myself almost always use todo_wine this
way, to reduce diff that remove todo_wine when implementation is fixed.
Actually not sure if todo_wine will trigger this check, does it?



More information about the wine-devel mailing list