[PATCH 2/3] xaudio2_7: Move source to shared xaudio2 directory

Andrew Eikum aeikum at codeweavers.com
Mon Jan 11 07:25:37 CST 2016


On Sun, Jan 10, 2016 at 11:32:22AM +1100, Alistair Leslie-Hughes wrote:
> Whats the reason behind moving the source into a separate directory?
> 
> It's not needed, have a look d3dcompiler_46 which uses the source in
> d3dcompiler_43.  If you have main.c in each directory the build script
> is smart enough to compile the correct one, if that is your concern.
> 

I didn't realize it was wrong. I was following the example of msvc*
which keeps their implementations in msvcrt/. However, we do need an
msvcrt DLL while we don't need an xaudio2 DLL. I didn't realize that
other modules like d3dcompiler use the shared source mechanism.

I don't understand why we keep the generic implementation in a
specific DLL, but if that's what we do, then OK.

Andrew



More information about the wine-devel mailing list