user32: Avoid -Wmisleading-indentation warnings and fix comments in comments in test_AppendMenu.
Dmitry Timoshkov
dmitry at baikal.ru
Tue Jan 12 01:10:55 CST 2016
Gerald Pfeifer <gerald at pfeifer.com> wrote:
> diff --git a/dlls/user32/tests/menu.c b/dlls/user32/tests/menu.c
> index 33d8eb8..ea965cd 100644
> --- a/dlls/user32/tests/menu.c
> +++ b/dlls/user32/tests/menu.c
> @@ -3992,13 +3992,15 @@ static void test_AppendMenu(void)
> mii.wID = 206;
> ret = InsertMenuItemA(hmenu, 0, TRUE, &mii);
> ok(ret, "InsertMenuItem failed\n");
> -if (0) /* FIXME: uncomment once Wine is fixed */
> +if (0) /* FIXME: enable once Wine is fixed */ {
> check_menu_items(hmenu, 206, MF_SEPARATOR, MFS_GRAYED);
> +}
> mii.wID = 207;
> ret = SetMenuItemInfoA(hmenu, 0, TRUE, &mii);
> ok(ret, "SetMenuItemInfo failed\n");
> -if (0) /* FIXME: uncomment once Wine is fixed */
> +if (0) /* FIXME: enable once Wine is fixed */ {
> check_menu_items(hmenu, 207, MF_SEPARATOR, MFS_GRAYED);
> +}
> DestroyMenu(hmenu);
>
> hbmp = CreateBitmap(1, 1, 1, 1, NULL);
Please don't make the code look uglier than it already is. I'd personally
argue that checking and forcing indentation rules by a C compiler is pretty
disappointing and actually misleading. That warning should be turned off by
default IMHO.
--
Dmitry.
More information about the wine-devel
mailing list