[PATCH] d3d11.idl: Add ID3D11VideoContext interface (try 2)

Jacek Caban jacek at codeweavers.com
Fri Jan 15 07:19:10 CST 2016


On 01/15/16 10:44, Henri Verbeet wrote:
> On 15 January 2016 at 09:30, Andrey Turkin <andrey.turkin at gmail.com> wrote:
>> 2016-01-15 3:35 GMT+03:00 Józef Kucia <joseph.kucia at gmail.com>:
>>> It would preferably be written as "UINT Usage : 1;". This applies to
>>> other bit fields.
>>
>> Make sense, will do
>>
> The main thing I'd personally be worried about would be the
> portability of bit fields. I think that in case of
> D3D11_VIDEO_PROCESSOR_COLOR_SPACE the layout ends up being the same
> between MSVC and gcc on x86, but I'm not sure that's something we can
> depend on, or if that also holds on different compilers or e.g.
> 64-bit.

I don't think this should block the patch. We already use bit fields in
Wine. Even if we ever find a problem with it (which is currently not the
case AFAIK) and we'd need something special for Wine, we should still
have a variant of declaration that is source compatible with PSDK
(except probably ifdefed).

Jacek



More information about the wine-devel mailing list