shell32/tests: Arrange for the shell_execute{_ex}() calls to set the test line.
Alexandre Julliard
julliard at winehq.org
Fri Jan 15 10:25:21 CST 2016
Francois Gouget <fgouget at codeweavers.com> writes:
> On Fri, 15 Jan 2016, Alexandre Julliard wrote:
>
>> Francois Gouget <fgouget at codeweavers.com> writes:
>>
>> > This makes it possible to attribute their internal test results to the relevant test_xxx() function.
>> > This implies that they must not make calls that would reset the test line.
>>
>> This is fragile.
>
> How so? This is how the ok() calls work.
winetest_set_location should be used only for a short amount of time,
like inside the ok() call. You can't assume that it's going to be
unchanged across a large function. Nobody is going to remember that this
function is special and can't use ok() like everywhere else.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list