[PATCH 1/1] d3drm/tests: Add texture loading tests.

[Aaryaman Vasishta]

On Fri, Jan 15, 2016 at 5:25 PM, Henri Verbeet <hverbeet at codeweavers.com>
wrote:

> +        for (i = 0; i < img->palette_size; ++i)
> +        {
> +            unsigned int idx = upside_down ? (h - 1) * w - i + (i % w) *
> 2 :
>
How did you come up with that equation? Would be nice to know :)

>
>
+
> +        hr = IDirect3DRM_LoadTexture(d3drm1, filename, &texture1);
> +        ok(SUCCEEDED(hr), "Test %u: Failed to load texture, hr %#x.\n",
> i, hr);
> +        d3drm_img = IDirect3DRMTexture_GetImage(texture1);
> +        todo_wine ok(!!d3drm_img, "Test %u: Failed to get image.\n", i);
>
 Why the '!!' ? How's that better than using a single negation?
Other than all that, I've mostly understood the changes you made. Patch
looks great :) I'll reply if I have any more queries on the same.

Cheers,
Aaryaman
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20160116/9f750287/attachment.html>