USER32: Remove unused variables xoffset, yoffset in SCROLL_TrackScrollBar
Nikolay Sivov
bunglehead at gmail.com
Sat Jan 16 06:16:19 CST 2016
On 16.01.2016 14:07, Carlo Bramini wrote:
> Hi dear friends,
> I'm replying here because I have not understood the assigned status as
> "Formatting" to the attached patch.
> Thank you very much for your time.
Hi, Carlo.
In your original patch you had this:
---
diff --git a/dlls/user32/scroll.c b/dlls/user32/scroll.c
old mode 100644
new mode 100755
---
so scroll.c file was given exec bit for some reason, I don't know how
that happened, but it did happen on your side, and git picked that change.
Next problem is missing Signed-of-by signature, you should have it for
all patches you send to wine-patches. No need to manually do so every
time, just configure git to include it automatically.
At the end what happened is that I re-submitted your patch with those
things fixed under your name and mine.
>
> Sincerely,
>
> Carlo Bramini.
>
>> ----Messaggio originale----
>> Da: Marvin <testbot at winehq.org>
>> Data: 11/01/2016 15.22
>> A: "Carlo Bramini"<carlo.bramix at libero.it>
>> Ogg: Re: USER32: Remove unused variables xoffset, yoffset in
> SCROLL_TrackScrollBar
>>
>> Thank you for your contribution to Wine!
>>
>> This is an automated notification to let you know that your patch has
>> been reviewed and its status set to "Formatting".
>>
>> This means that there are some formatting issues with your
>> patch. Either the author's full name, email address, or Signed-off-by
>> headers are missing, indentation is messed up (usually from editing
>> with a non-standard tab size), or there are gratuitous formatting
>> changes to the code. You need to resend a fixed patch.
>>
>> If you do not understand the reason for this status, disagree with our
>> assessment, or are simply not sure how to proceed next, please ask for
>> clarification by replying to this email.
>
>
>
>
More information about the wine-devel
mailing list