[PATCH 1/2] wpcap: Implement pcap_dump_open and pcap_dump

[André Hentschel]

Hi,

Sorry for the delay, but I haven't noticed that I got assigned for reviewing.
Could you please tell me the name of the application so I can do some testing?
Further reviewing inlined below:

Am 07.01.2016 um 09:49 schrieb Jianqiu Zhang:
> +
> +pcap_dumper_t* CDECL wine_pcap_dump_open(pcap_t *p, const char *fname)
> +{
> +    return pcap_dump_open(p, fname);
> +}

This can't work, the wpcap function might be called with fname set to "C:\dump.pcap" and the native function will be confused by that.

> +void CDECL wine_pcap_dump(u_char *user, const struct pcap_pkthdr *h, const u_char *sp)
> +{
> +    return pcap_dump(user, h, sp);
> +}

This should work, but where are pcap_dump_close and friends?

> diff --git a/dlls/wpcap/wpcap.spec b/dlls/wpcap/wpcap.spec
> index 0e1e208..d7efd5e 100644
> --- a/dlls/wpcap/wpcap.spec
> +++ b/dlls/wpcap/wpcap.spec
> @@ -16,12 +16,12 @@
> @ cdecl pcap_datalink_val_to_description(long) wine_pcap_datalink_val_to_description
> @ cdecl pcap_datalink_val_to_name(long) wine_pcap_datalink_val_to_name
> @ cdecl pcap_dispatch(ptr long ptr ptr) wine_pcap_dispatch
> -@ stub pcap_dump
> +@ cdecl pcap_dump(str ptr str) wine_pcap_dump

Should be (ptr ptr ptr), there are no strings to be displayed