[PATCH 4/7] ddraw/tests: Add tests for invalid render states.

Józef Kucia joseph.kucia at gmail.com
Fri Jan 29 03:38:22 CST 2016


On Thu, Jan 28, 2016 at 2:51 PM, Henri Verbeet <hverbeet at gmail.com> wrote:
> On 28 January 2016 at 00:17, Józef Kucia <jkucia at codeweavers.com> wrote:
>> Signed-off-by: Józef Kucia <jkucia at codeweavers.com>
>> ---
>> Tested on Windows 7 and 10.
>>
>> A similar test crashes in ddraw1.
>>
>> I'm also not sure if this test is safe for ddraw7 as it seems to crash
>> with higher values.
>
> Yeah, it probably corrupts memory in ddraw7. What does GetRenderState() do?
>

GetRenderState() returns the expected values but it fails for some
invalid state values with DDERR_INVALIDPARAMS. A ddraw7 device is also
usable after setting invalid states (I was able to draw something
after setting invalid states). Nevertheless, I doubt it's enough
indication of anything.



More information about the wine-devel mailing list