[PATCH 3/3] regedit: Process the next file, if any, on error (v2)
Hugh McMaster
hugh.mcmaster at outlook.com
Tue Jul 5 19:51:51 CDT 2016
On Wednesday, 6 July 2016 12:09 AM, Sebastian Lackner wrote:
>On 05.07.2016 11:13, Hugh McMaster wrote:
>> @@ -113,7 +113,9 @@ static BOOL PerformRegAction(REGEDIT_ACTION action, WCHAR **argv, int *i)
>> if (size == 0)
>> {
>> output_message(STRING_FILE_NOT_FOUND, filename);
>> - exit(1);
>> + if (realname)
>> + HeapFree(GetProcessHeap(), 0, realname);
>
> I haven't reviewed the whole series, but passing a NULL pointer to HeapFree()
> is perfectly fine, and its better to avoid such checks.
Okay, thanks for pointing that out. Alexandre has already fixed this in both places
(see http://source.winehq.org/git/wine.git/commitdiff/6ad44d7a3190d8e9a3daa9bd723980e5c4320b42),
so no action is necessary.
Thanks for the review.
More information about the wine-devel
mailing list