[PATCH] server: Move the \BaseNamedObjects symlink from \Sessions\0 to \Sessions\1\BaseNamedObjects.

[Sebastian Lackner]

On 08.07.2016 03:05, flan wrote:
> On Fri, Jul 08, 2016 at 01:17:01AM +0200, Sebastian Lackner wrote:
>> I'm not the maintainer of this component, but Alex is right that you
>> will have to use your real name (both as author and also in the
>> Signed-off-by message).
>>
>> I also believe that the variable names link_bno1W and link_bno1_str
>> are chosen a bit badly. The 1 does not really make any sense, and instead
>> of "bno" it might be better to use the same abbreviation "basenamed" as
>> above. If you make any changes, please also adjust the whitespace
>> inbetween of the variable name and "=" to match the surrounding code.
>>
>> If \\Sessions\\1 contains all the elements from \\, you could also
>> think about symlinking it to root (instead of symlinking each component
>> separately).
>>
>> Regards,
>> Sebastian
>>
> 
> Thank you for the feedback, I'll change variable names and adjust the
> whitespace. \\Sessions\\1 does not seem to contain all elements from \\. The
> only element besides BaseNamedObjects that's both in \\ and \\Sessions\\1
> seems to be \\Windows and its child directory, WindowStations.

Okay, then the current approach should be fine.

> 
> Is there any particular reason behind the real name requirement?
> 

For the Wine project it is very important to make sure that all developers
are trustworthy and that they do not violate any laws, for example by
disassembling or looking at original Microsoft code. You can find more about
the requirements and guidelines on the following pages:

https://wiki.winehq.org/Submitting_Patches
https://wiki.winehq.org/Clean_Room_Guidelines

Although your patch is just a simple fix, for reasons of simplicity the rules
are the same for all kind of submissions.