[v3 1/2] winejoystick.drv: Print location ID in debugstr_device on the Mac

DavidL david.dljunk at gmail.com
Mon Jul 11 03:35:40 CDT 2016


Actually it looks like I am going to make a slight change to
device_location_comparator to get rid of another set of compilation
warnings - I took a look at button_usage_comparator and modeled the new
version after that which eliminated the warning messages.

Cheers,
David

On Sun, Jul 10, 2016 at 10:25 PM, DavidL <david.dljunk at gmail.com> wrote:

> Hi Ken,
>
> Thanks, I'll make the changes. For the dinput & winmm patch 2/3 & 2/2,
> should I resubmit them as part of my version 4 of the overall patches even
> if they have been signed-off on? (although I think only the dinput one was
> signed off on) I'm not anticipating making any changes to signed-off
> sorting code patch based on the comments.
>
> Cheers,
> David
>
> On Sun, Jul 10, 2016 at 3:36 PM, Ken Thomases <ken at codeweavers.com> wrote:
>
>> On Jun 30, 2016, at 7:02 PM, David Lawrie <david.dljunk at gmail.com> wrote:
>> >
>> > Tested on OS X 10.10.5.
>> >
>> > Signed-off-by: David Lawrie <david.dljunk at gmail.com>
>> > ---
>> > dlls/winejoystick.drv/joystick_osx.c | 30 ++++++++++++++++++++++++++++--
>> > 1 file changed, 28 insertions(+), 2 deletions(-)
>>
>> This has similar issues as the dinput version, the main one being the
>> pointless "result" variable in get_device_property_long().
>>
>> -Ken
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20160711/679a2f83/attachment.html>


More information about the wine-devel mailing list