[PATCH 4/4] d3drm: Implement IDirect3DRMDevice*::Add/DeleteDestroyCallback. (v2)

Thu Jul 14 13:50:31 CDT 2016

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2016-07-11 um 08:46 schrieb Aaryaman Vasishta:
> Umm, It's still not clear whether the interface is QI'd to 
> IDirect3DRMObject or referenced directly. Our implementation
> doesn't do the AddRef, but I don't think refcounting matters much
> in this case, since the callbacks happen right before the object
> gets destroyed.
For the mailing list archives: We talked about this on IRC, and it
turns out that native always passes the version 1 interface to the
callback, regardless of which version was used to call
AddDestroyCallback. (or rather, it passes the IDirect3DRMObject
interface, which happens to share the vtable with the version 1
interface in all objects as far as we know.

Our code already implements this behavior.