[PATCH] kernel32: Implement SetConsoleFont

Sebastian Lackner sebastian at fds-team.de
Tue Jul 19 07:52:12 CDT 2016


On 19.07.2016 14:34, Hugh McMaster wrote:
> Signed-off-by: Hugh McMaster <hugh.mcmaster at outlook.com>
> ---
>  dlls/kernel32/console.c       | 27 ++++++++++++++++++++++++---
>  dlls/kernel32/tests/console.c |  6 +++---
>  2 files changed, 27 insertions(+), 6 deletions(-)
> 

It looks like your code requests the font size from the wineserver (GetConsoleFontSize)
just to send it back immediately afterwards. Is that intentional? And wouldn't it make
more sense to implement support for multiple font sizes first?

Also, please note that the GetNumberOfConsoleFonts() check is unnecessary because
GetConsoleFontSize() already takes care of that.




More information about the wine-devel mailing list